From b0601f2be7df28d3fab982344a2cc0df8960b012 Mon Sep 17 00:00:00 2001 From: Anders Damsgaard Date: Wed, 6 Jan 2021 11:51:59 +0100 Subject: do not suppress compilation output with the @ prefix As "Considerations" in bitreich-style/c/makefile-guideline.txt: >87 * It is not recommended to suppress compilation output with the @ prefix (for >88 example to make output look nicer aligned). The verbose output is very useful >89 for debugging and suppressing it only adds debugging abstractions. --- Makefile | 41 ++++++++++++++++++++--------------------- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/Makefile b/Makefile index bbd9fe0..eb7d1f4 100644 --- a/Makefile +++ b/Makefile @@ -28,30 +28,29 @@ debug: clean ${MAKE} CFLAGS="${DEBUG}" all clean: - @echo cleaning - @rm -f xml2tsv ${OBJ} + rm -f xml2tsv ${OBJ} install: all - @echo installing executable to ${DESTDIR}${BINDIR} - @mkdir -p "${DESTDIR}${BINDIR}" - @cp -f xml2tsv "${DESTDIR}${BINDIR}" - @chmod 755 "${DESTDIR}${BINDIR}/xml2tsv" - @echo installing man page to ${DESTDIR}${MANPREFIX} - @mkdir -p ${DESTDIR}${MANPREFIX}/man1 - @cp -f ${MAN1} ${DESTDIR}${MANPREFIX}/man1 - @for f in ${MAN1}; do chmod 644 ${DESTDIR}${MANPREFIX}/man1/$$f; done + # installing executable to ${DESTDIR}${BINDIR} + mkdir -p "${DESTDIR}${BINDIR}" + cp -f xml2tsv "${DESTDIR}${BINDIR}" + chmod 755 "${DESTDIR}${BINDIR}/xml2tsv" + # installing man page to ${DESTDIR}${MANPREFIX} + mkdir -p ${DESTDIR}${MANPREFIX}/man1 + cp -f ${MAN1} ${DESTDIR}${MANPREFIX}/man1 + for f in ${MAN1}; do chmod 644 ${DESTDIR}${MANPREFIX}/man1/$$f; done uninstall: - @echo removing executable file from ${DESTDIR}${BINDIR} - @rm -f "${DESTDIR}${BINDIR}/xml2tsv" - @echo removing man pages ${DESTDIR}${MANPREFIX} - @for f in ${MAN1}; do rm -f ${DESTDIR}${MANPREFIX}/man1/$$f; done + # removing executable file from ${DESTDIR}${BINDIR} + rm -f "${DESTDIR}${BINDIR}/xml2tsv" + # removing man pages ${DESTDIR}${MANPREFIX} + for f in ${MAN1}; do rm -f ${DESTDIR}${MANPREFIX}/man1/$$f; done dist: clean - @echo "making a tarball" - @mkdir -p ./xml2tsv-${VERSION} - @rm -rf ./xml2tsv-${VERSION}/* - @cp -R ${DISTFILES} ./xml2tsv-${VERSION}/ - @tar -cf xml2tsv-${VERSION}.tar ./xml2tsv-${VERSION} - @gzip xml2tsv-${VERSION}.tar - @rm -rf xml2tsv-${VERSION} + # make a tarball + mkdir -p ./xml2tsv-${VERSION} + rm -rf ./xml2tsv-${VERSION}/* + cp -R ${DISTFILES} ./xml2tsv-${VERSION}/ + tar -cf xml2tsv-${VERSION}.tar ./xml2tsv-${VERSION} + gzip xml2tsv-${VERSION}.tar + rm -rf xml2tsv-${VERSION} -- cgit v1.2.3