From 3d8a6507ca542881a5e8b30ad6b7068a9c4fdeea Mon Sep 17 00:00:00 2001 From: John Keeping Date: Sun, 12 Jan 2014 17:13:50 +0000 Subject: filter: pass extra arguments via cgit_open_filter This avoids poking into the filter data structure at various points in the code. We rely on the fact that the number of arguments is fixed based on the filter type (set in cgit_new_filter) and that the call sites all know which filter type they're using. Signed-off-by: John Keeping --- ui-tree.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'ui-tree.c') diff --git a/ui-tree.c b/ui-tree.c index 5ae3926..e4c3d22 100644 --- a/ui-tree.c +++ b/ui-tree.c @@ -45,13 +45,12 @@ static void print_text_buffer(const char *name, char *buf, unsigned long size) } if (ctx.repo->source_filter) { + char *filter_arg = xstrdup(name); html("
");
-		ctx.repo->source_filter->argv[1] = xstrdup(name);
-		cgit_open_filter(ctx.repo->source_filter);
+		cgit_open_filter(ctx.repo->source_filter, filter_arg);
 		html_raw(buf, size);
 		cgit_close_filter(ctx.repo->source_filter);
-		free(ctx.repo->source_filter->argv[1]);
-		ctx.repo->source_filter->argv[1] = NULL;
+		free(filter_arg);
 		html("
\n"); return; } -- cgit v1.2.3